Moved UserMode from PortalSettings to Personalization class (#4225) * Moved UserMode from PortalSettings to Personalization class Closes #4213 I am open to any feedback on this, I do believe this way would not be a breaking change... * Update DNN Platform/Library/Services/Personalization/Personalization.cs Co-authored-by: Brian Dukes <[email protected]> * Update DNN Platform/Library/Services/Personalization/Personalization.cs Co-authored-by: Brian Dukes <[email protected]> * Prevent duplication of code Co-authored-by: Brian Dukes <[email protected]>
Merge pull request #4226 from joshgk00/Issue3791 Updated .NET & SQL requirements in InstallWizard localization files
Updated .NET Framework requirement in InstallWizard localization files from 4.0 to 4.7.2. also removed mention of older OS versions from the FileAndFolderPermissionCheckFailed.Text key in the InstallWizard localization files
Merge pull request #4223 from berkarslan-xo/bugfix/Issue-4222 Issue-4222 - Registration Module system messages use an incorrect language
Merge pull request #4218 from zyhfish/bug/issue-4217 avoid I/O process frequency during export process.
Issue-4222 - MembershipModule CurrentCulture fix
Ensure comments are only inserted when necessary Fix #4219
avoid I/O process frequency during export process. Fix #4217
Merge pull request #4210 from dnnsoftware/david-poindexter-patch-1 Remove impractical rule
Resolves 1793 build warnings in Library project (#4204) * Resolves 1793 build warnings in DotNetNuke.Collections This PR covers pretty much all the Collections folder. I am no expert in this area, so any feedback on the documentation is welcome * Update DNN Platform/Library/Collections/LockingStrategy.cs Co-authored-by: Brian Dukes <[email protected]> * Update DNN Platform/Library/Collections/MonitorLock.cs Co-authored-by: Brian Dukes <[email protected]> * Update DNN Platform/Library/Collections/MonitorLock.cs Co-authored-by: Brian Dukes <[email protected]> * Update DNN Platform/Library/Collections/NaiveLockingList.cs Co-authored-by: Brian Dukes <[email protected]> * Update DNN Platform/Library/Collections/NaiveLockingList.cs Co-authored-by: Brian Dukes <[email protected]> * Update DNN Platform/Library/Collections/SharedList.cs Co-authored-by: Brian Dukes <[email protected]> * Update DNN Platform/Library/Common/Lists/CachedCountryList.cs Co-authored-by: Brian Dukes <[email protected]> * Update DNN Platform/Library/Common/Lists/ListInfo.cs Co-authored-by: Brian Dukes <[email protected]> * Update DNN Platform/Library/Common/NavigationManager.cs Co-authored-by: Brian Dukes <[email protected]> * Update DNN Platform/Library/Common/ServiceScopeContainer.cs Co-authored-by: Brian Dukes <[email protected]> * Update DNN Platform/Library/Collections/ReaderWriterSlimLock.cs Co-authored-by: Brian Dukes <[email protected]> * Update DNN Platform/Library/Collections/SharedDictionary.cs Co-authored-by: Brian Dukes <[email protected]> * Implemented CLSCompliant attribute on DotNetNuke.Abstractions and DotNetNuke.DependencyInjection * Marked IDNNStartup as not CSL Compliant * Update DNN Platform/Library/Services/Journal/JournalControllerImpl.cs Co-authored-by: David Poindexter <[email protected]> * Update DNN Platform/Library/Services/Scheduling/DNNScheduler.cs Co-authored-by: David Poindexter <[email protected]> * Update DNN Platform/Library/Services/Search/Internals/LuceneControllerImpl.cs Co-authored-by: David Poindexter <[email protected]> Co-authored-by: Brian Dukes <[email protected]> Co-authored-by: David Poindexter <[email protected]>
Remove impractical rule @dnnsoftware/approvers I'm thinking this is a bit overkill, as I can't think of a reason why it would matter who actually clicks the merge button. The important thing is that there are two approvals. Do you all agree?
Update DNN Platform/Admin Modules/Dnn.Modules.Console/Components/BusinessController.cs
Removed an unused private variable that was missed
Fixes all warnings in the Console module - Resolves all stylecop warnings in the Console Admin Module - Enables TreatWarningsAsErrors on that project
Merge pull request #4194 from valadas/stylecop-20201015 Resolves multiple stylcop warnings in Library and HttpModules projects
Merge pull request #4198 from engineering87/develop Fix tooltip Sitemap page priority
Resolved merge conflicts
Fixed whitespace for consistency Co-authored-by: Brian Dukes <[email protected]>
Fixed an issue where the autocomplete on the country/region field would show the Id instead of the name when using the arrow keys to navigate the autocomplete suggestions
Updated parameter with LoginTabId instead of TabName